Messages in this thread | | | Date | Mon, 5 Oct 2015 09:28:00 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP |
| |
On Fri, 02 Oct 2015, Andy Shevchenko wrote:
> On Thu, 2015-10-01 at 15:45 +0100, Lee Jones wrote: > > On Thu, 01 Oct 2015, Andy Shevchenko wrote: > > > > > Jim Davis reported the compilation error with a random > > > configuration which > > > apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that > > > conditions we have > > > missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here. > > > > > > Reported-by: Jim Davis <jim.epost@gmail.com> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > > drivers/mfd/intel-lpss.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Why are you using this email address? > > In fact it *had* the proper address [1] and after you confused me [2]. > > [1] http://www.spinics.net/lists/kernel/msg2073973.html
This was the original patch submission, which was correct.
https://lkml.org/lkml/2015/10/1/484
However this email you sent to the wrong address.
> [2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html
Then you followed up with a patch, also to the wrong address.
BTW: This patch has already been applied to my -fixes branch and will be sent to Mainline in a week or so.
> > Please use ./get_maintainer.pl properly. > > > > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h > > > index f28cb28a..2c7f8d7 100644 > > > --- a/drivers/mfd/intel-lpss.h > > > +++ b/drivers/mfd/intel-lpss.h > > > @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); > > > .thaw = intel_lpss_resume, \ > > > .poweroff = intel_lpss_suspend, \ > > > .restore = intel_lpss_resume, > > > +#else > > > +#define INTEL_LPSS_SLEEP_PM_OPS > > > #endif > > > > > > #define INTEL_LPSS_RUNTIME_PM_OPS \ >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |