lkml.org 
[lkml]   [2015]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/12] KVM: x86: Add a common TSC scaling ratio field in kvm_vcpu_arch
    2015-09-28 13:38+0800, Haozhong Zhang:
    > This patch moves the field of TSC scaling ratio from the architecture
    > struct vcpu_svm to the common struct kvm_vcpu_arch.
    >
    > Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
    > ---
    > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
    > @@ -7080,6 +7080,9 @@ struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm,
    >
    > vcpu = kvm_x86_ops->vcpu_create(kvm, id);
    >
    > + if (!IS_ERR(vcpu))
    > + vcpu->arch.tsc_scaling_ratio = kvm_default_tsc_scaling_ratio;

    This shouldn't be necessary, (and we can definitely do it without error
    checking later)

    kvm_arch_vcpu_create
    (vmx|svm)_create_vcpu
    kvm_vcpu_init
    kvm_arch_vcpu_init
    kvm_set_tsc_khz

    sets vcpu->arch.tsc_scaling_ratio to something reasonable and SVM didn't
    overwrite that value. (kvm_set_tsc_khz() only doesn't set the ration if
    this_tsc_khz == 0, which we could extend to be extra safe.)


    \
     
     \ /
      Last update: 2015-10-05 21:41    [W:4.090 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site