lkml.org 
[lkml]   [2015]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: adc: fix comment block coding style issue
On 10/03/2015 08:32 PM, Hugo Camboulive wrote:
> This patch to ad7746.c makes the comment block end with a */
> on a separate line.
>
> Signed-off-by: Hugo Camboulive <hugo.camboulive@gmail.com>
> ---
> drivers/staging/iio/cdc/ad7746.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 10fa372..8445ddd 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -531,7 +531,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev,
> /* CAPDAC Scale = 21pF_typ / 127
> * CIN Scale = 8.192pF / 2^24
> * Offset Scale = CAPDAC Scale / CIN Scale = 338646
> - * */
> + */

Looks good, but while you are at it please also fix the beginning of the
comment. Kernel style multi-line comments look like

/*
* text
* more text
*/

So the line with the /* should have any text.

Bonus points if you can also fix all other occurrences of this style error
in the same file.

- Lars



\
 
 \ /
  Last update: 2015-10-04 14:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog