Messages in this thread | | | Date | Sun, 4 Oct 2015 19:04:06 -0700 | From | Davidlohr Bueso <> | Subject | Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON() |
| |
On Sun, 04 Oct 2015, Leon Romanovsky wrote:
>On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang <geliangtang@163.com> wrote: >> BUG_ON() already contain an unlikely compiler flag. Drop it. >It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not set.
Yeah, but that's like the 1% of the cases -- and those probably don't even care about the branch prediction (I could be wrong). So overall I like getting rid of explicit BUG_ON(unlikely(... calls. In fact there's a _reason_ why there are so few of them in the kernel.
Thanks, Davidlohr
| |