lkml.org 
[lkml]   [2015]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/3] uio_pci_generic: add MSI/MSI-X support
Hi Vlad,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: xtensa-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

All error/warnings (new ones prefixed by >>):

drivers/uio/uio_pci_generic.c: In function 'uio_pci_generic_ioctl':
>> drivers/uio/uio_pci_generic.c:189:3: error: implicit declaration of function 'copy_from_user' [-Werror=implicit-function-declaration]
if (copy_from_user(&hdr, (void __user *)arg, sizeof(hdr)))
^
>> drivers/uio/uio_pci_generic.c:208:4: error: implicit declaration of function 'put_user' [-Werror=implicit-function-declaration]
err = put_user(0, (u32 __user *)arg);
^
cc1: some warnings being treated as errors

vim +/copy_from_user +189 drivers/uio/uio_pci_generic.c

183 struct uio_pci_generic_dev *gdev = to_uio_pci_generic_dev(info);
184 struct uio_pci_generic_irq_set hdr;
185 int err;
186
187 switch (cmd) {
188 case UIO_PCI_GENERIC_IRQ_SET:
> 189 if (copy_from_user(&hdr, (void __user *)arg, sizeof(hdr)))
190 return -EFAULT;
191
192 /* Locking is needed to ensure two things:
193 * 1) Two IRQ_SET ioctl()'s are not running in parallel.
194 * 2) IRQ_SET ioctl() is not running in parallel with remove().
195 */
196 mutex_lock(&gdev->msix_state_lock);
197 if (gdev->int_mode != UIO_INT_MODE_MSIX) {
198 mutex_unlock(&gdev->msix_state_lock);
199 return -EOPNOTSUPP;
200 }
201
202 err = set_irq_eventfd(gdev, hdr.vec, hdr.fd);
203 mutex_unlock(&gdev->msix_state_lock);
204
205 break;
206 case UIO_PCI_GENERIC_IRQ_NUM_GET:
207 if (gdev->int_mode == UIO_INT_MODE_NONE)
> 208 err = put_user(0, (u32 __user *)arg);
209 else if (gdev->int_mode != UIO_INT_MODE_MSIX)
210 err = put_user(1, (u32 __user *)arg);
211 else

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2015-10-04 19:21    [W:0.043 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site