lkml.org 
[lkml]   [2015]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] signal: turn dequeue_signal_lock() into kernel_dequeue_signal()
On Sat, Oct 03, 2015 at 08:13:36PM +0200, Oleg Nesterov wrote:
> 1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This
> matches another "for kthreads only" kernel_sigaction() helper.
>
> 2. Remove the "tsk" and "mask" arguments, they are always current
> and current->blocked. And it is simply wrong if tsk != current.
>
> 3. We could also remove the 3rd "siginfo_t *info" arg but it looks
> potentially useful. However we can simplify the callers if we
> change kernel_dequeue_signal() to accept info => NULL.
>
> 4. Remove _irqsave, it is never called from atomic context.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

FWIW, looks good to me.

Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-10-04 19:01    [W:0.496 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site