lkml.org 
[lkml]   [2015]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/24] ver_linux: echo.patch
Your subject is really "odd", it doesn't really describe what you are
doing in a single line, it just has a file name in it :(

What did you use to generate these? I got a few duplicates, and there
isn't a "leading" 0 for the first 9 patches. git can spit these out
correctly very simply, I recommend using that in the future.

On Sat, Oct 03, 2015 at 03:57:08PM +0300, Alexander Kapshuk wrote:
> While not a problem in itself, I was not sure why 'echo space' was used.
> Not being aware of any immediate benefits to this, I thought using
> 'echo' by itself would suffice in printing a newline, which I believe is
> the desired behaviour.
>
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
> --- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300
> +++ linux/scripts/ver_linux 2015-10-03 13:43:38.587271851 +0300
> @@ -6,10 +6,10 @@
> #
> echo 'If some fields are empty or look unusual you may have an old version.'
> echo 'Compare to the current minimal requirements in Documentation/Changes.'
> -echo ' '
> +echo
>
> uname -a
> -echo ' '
> +echo

Can you respin these patches with correct subject lines, based on this,
and the other feedback you have gotten and resend them?

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-10-04 18:41    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog