Messages in this thread | | | Date | Sat, 31 Oct 2015 17:11:16 -0700 | From | Brian Norris <> | Subject | Re: [PATCH v2 09/11] mtd: drop unnecessary partition parser data |
| |
On Sat, Oct 31, 2015 at 04:26:32PM +0100, Marek Vasut wrote: > On Saturday, October 31, 2015 at 04:33:28 AM, Brian Norris wrote: > > - mtd_device_parse_register(info->cmtd, part_probe_types, &ppdata, > > + mtd_device_parse_register(info->cmtd, part_probe_types, NULL, > > Did you miss this one ?
What about it? I removed the parser data (the third argument), but I can't yet drop the 2nd argument, since those parser types are different than the defaults. So I can't drop any more arguments, nor can I convert this to mtd_device_register().
(Now, I'd like to improve the device tree handling of parser types, so we don't need any more specialized handling in drivers like this.)
> > NULL, 0); > > of_free_probes(part_probe_types); > > > > > This is really good, I like to see the ppdata nonsense finally going away. > > Reviewed-by: Marek Vasut <marex@denx.de>
Thanks for the review! I'm happy to kill off much of this nonsense too. And I think this will help in the long run on some other things too, since now we have a canonical place to put common MTD bindings.
Brian
| |