lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] __div64_32: implement division by multiplication for 32-bit arches
On Fri, 30 Oct 2015, Alexey Brodkin wrote:

> Hi Nicolas,
>
> On Fri, 2015-10-30 at 11:17 -0400, Nicolas Pitre wrote:
> > On Fri, 30 Oct 2015, Måns Rullgård wrote:
> >
> > > Nicolas Pitre <nicolas.pitre@linaro.org> writes:
> > >
> > > > OK... I was intrigued, so I adapted my ARM code to the generic case,
> > > > including the overflow avoidance optimizations. Please have look and
> > > > tell me how this works for you.
> > > >
> > > > If this patch is accepted upstream, then it could be possible to
> > > > abstract only the actual multiplication part with some architecture
> > > > specific assembly.
> > >
> > > Good idea.
> >
> > Could you please provide a reviewed-by or acked-by tag?
>
> Sure!
>
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
>
> BTW I thought about that optimization a bit more and now I think
> we may even skip addition of arch-specific assembly insertions.

I'm going to do it anyway given that I already have it for ARM. It'll
be opt-in, so if your arch doesn't provide it then the current C
implementation will be used by default.


Nicolas
\
 
 \ /
  Last update: 2015-10-30 18:01    [W:0.140 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site