Messages in this thread | | | From | Jake Oshins <> | Subject | RE: [PATCH v4 4/7] PCI: Add fwnode_handle to pci_sysdata | Date | Fri, 30 Oct 2015 16:01:41 +0000 |
| |
> -----Original Message----- > From: Jiang Liu [mailto:jiang.liu@linux.intel.com] > Sent: Thursday, October 29, 2015 6:55 PM > To: Jake Oshins <jakeo@microsoft.com>; gregkh@linuxfoundation.org; KY > Srinivasan <kys@microsoft.com>; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > vkuznets@redhat.com; tglx@redhat.com; Haiyang Zhang > <haiyangz@microsoft.com>; marc.zyngier@arm.com; > bhelgaas@google.com; linux-pci@vger.kernel.org > Subject: Re: [PATCH v4 4/7] PCI: Add fwnode_handle to pci_sysdata >
> > > > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN > > +static inline void *pci_fwnode(struct pci_bus *bus) > > +{ > > + struct pci_sysdata *sd = bus->sysdata; > > + return sd->fwnode; > > +} > > +#endif > Hi Jakeo, > I would be better that if the function name indicates > that we are getting PCI host bridge(root bus) firmware node. > And you also need some magic here to avoid breaking compilation > on other archs: > in arch/x86/include/asm/pci.h > #define pci_fwnode pci_fwnode > > in include/asm-generic/pci.h > #ifndef pci_fwnode > #define pci_fwnode(bus) ((void)(bus),NULL) > #endif > > Thanks, > Gerry
Got it. Thanks. I'll fix and resend.
-- Jake Oshins
| |