lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 UPDATE-2 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM
From
Date
On Fri, 2015-10-30 at 10:40 +0100, Borislav Petkov wrote:
> On Mon, Oct 26, 2015 at 03:22:24PM -0600, Toshi Kani wrote:
> > @@ -545,10 +545,15 @@ static int einj_error_inject(u32 type, u32 flags, u64
> > param1, u64 param2,
> > /*
> > * Disallow crazy address masks that give BIOS leeway to pick
> > * injection address almost anywhere. Insist on page or
> > - * better granularity and that target address is normal RAM.
> > + * better granularity and that target address is normal RAM or
> > + * NVDIMM.
> > */
> > - pfn = PFN_DOWN(param1 & param2);
> > - if (!page_is_ram(pfn) || ((param2 & PAGE_MASK) != PAGE_MASK))
> > + base_addr = param1 & param2;
> > + size = (~param2) + 1;
>
> Hmm, I missed this last time: why are the brackets there?
>
> AFAIK, bitwise NOT has a higher precedence than addition.

Yes, the brackets are not necessary. I put them as self-explanatory of the
precedence. Shall I remove them, and send you an updated patch?

Thanks,
-Toshi


\
 
 \ /
  Last update: 2015-10-30 15:01    [W:0.053 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site