Messages in this thread | | | Subject | Re: [PATCH] Revert "h8300: clocksource" | From | Daniel Lezcano <> | Date | Fri, 30 Oct 2015 12:48:52 +0100 |
| |
On 10/30/2015 12:19 PM, Arnd Bergmann wrote: > On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote: >> This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483.
[ ... ]
> I found that Yoshinori Sato has always addressed all review comments very > quickly by rewriting the code in a proper manner when mistakes were > pointed out in the other drivers. Maybe you can describe now what the > problems are with the three drivers to give him a chance to fix them?
I agree it is a good argument to give him the opportunity to fix the code.
Yoshinori Sato, can you please do a cleanup in the init functions to comply with the other drivers, use CLOCKSOURCE_OF_DECLARE and remove the module exit code ?
Thanks.
-- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |