lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling device registered
Date
Hi, Javi,
thanks for your review,
will send a version 3 out soon.

> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@arm.com]
> Sent: Wednesday, October 28, 2015 6:40 PM
> To: Chen, Yu C
> Cc: Zhang, Rui; edubezval@gmail.com; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: Re: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling
> device registered
>
> Hi Yu,
>
> One minor nit below. Other than that you can add my
>
> Reviewed-by: Javi Merino <javi.merino@arm.com>
>
> On Mon, Oct 26, 2015 at 11:15:30AM +0800, Chen Yu wrote:
> > When a new cooling device is registered, we need to update the thermal
> > zone to set the new registered cooling device to a proper state.
> >
> > This fixes a problem that the system is cool, while the fan devices
> > are left running on full speed after boot, if fan device is registered
> > after thermal zone device.
> >
> > Here is the history of why current patch looks like this:
> > https://patchwork.kernel.org/patch/7273041/
> >
> > CC: <stable@vger.kernel.org> #3.18+
> > Reference:https://bugzilla.kernel.org/show_bug.cgi?id=92431
> > Tested-by: Manuel Krause <manuelkrause@netscape.net>
> > Tested-by: szegad <szegadlo@poczta.onet.pl>
> > Tested-by: prash <prash.n.rao@gmail.com>
> > Tested-by: amish <ammdispose-arch@yahoo.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > ---
> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h index
> > 5bcabc7..4298418 100644
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -195,6 +195,7 @@ struct thermal_zone_device {
> > int emul_temperature;
> > int passive;
> > unsigned int forced_passive;
> > + atomic_t need_update;
>
> Please document this field in the kernel-doc comment for struct
> thermal_zone_device.
>

Best Regards,
Yu

\
 
 \ /
  Last update: 2015-10-30 09:41    [W:0.066 / U:8.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site