lkml.org 
[lkml]   [2015]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ebpf, events: make it actually more configurable

* Daniel Borkmann <daniel@iogearbox.net> wrote:

> On 10/03/2015 08:37 AM, Ingo Molnar wrote:
> >
> >* Daniel Borkmann <daniel@iogearbox.net> wrote:
> >
> >>While testing some other BPF issue, I realized that BPF_EVENTS is
> >>actually not accessible through menuconfig because of a missing
> >>description that needs to be attached to the bool. After the patch
> >>the entry shows up in menuconfig and can be enabled/disabled from
> >>there.
> >
> > Yeah, so the principle is the following: the main configuration option for it
> > is BPF_SYSCALL. The BPF_EVENTS is an internal detail, always enabled when
> > possible, and we make it so that if the BPF syscall is enabled, we'll enable
> > the perf integration if all the must-have components are in place:
>
> Makes sense, yes. I probably got confused due to the help text on the hidden
> Kconfig entry, but that can nevertheless serve as documentation purpose.

Feel free to send a patch that adds a sentence to that help text that explains
that this is an internal helper Kconfig entry that does not need to be
interactively configurable.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-10-03 10:41    [W:1.835 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site