lkml.org 
[lkml]   [2015]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/5] net: dsa: add missing kfree on remove
From
Date
Hello.

On 10/3/2015 5:25 PM, Neil Armstrong wrote:

> To prevent memory leakage on unbinding, add missing kfree calls.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> net/dsa/dsa.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index c59fa5d..12cec40 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -914,8 +914,10 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
> for (i = 0; i < dst->pd->nr_chips; i++) {
> struct dsa_switch *ds = dst->ds[i];
>
> - if (ds != NULL)
> + if (ds != NULL) {

Didn;t scripts/checkpatch.pl complain here? just if (ds) is preferred in
the networking code.

MBR, Sergei



\
 
 \ /
  Last update: 2015-10-03 17:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog