lkml.org 
[lkml]   [2015]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 21/24] ver_linux: sh-utils.patch
Using 'awk' here is a bit of an overkill. Should the output of 'expr --v'
vary on another disto, or change overtime, it may no longer be available
in the last field, as relied on by the current implementation.
I believe 'sed' offers greater flexibility here in terms of processing
varying output as well as being more light-weight.


Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux 2015-10-03 14:00:24.812214544 +0300
@@ -85,7 +85,13 @@
oprofiled --version 2>&1 | awk \
'(NR==1 && ($2 == "oprofile")) {print "oprofile ", $3}'

-expr --v 2>&1 | awk 'NR==1{print "Sh-utils ", $NF}'
+test -x "$expr" &&
+$expr --v 2>&1 |
+sed '
+ /^expr/!d
+ s/[^0-9.]//g
+ s/^/Sh-utils\t\t/
+'

udevinfo -V 2>&1 | grep version | awk '{print "udev ", $3}'

\
 
 \ /
  Last update: 2015-10-03 16:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog