lkml.org 
[lkml]   [2015]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 14/24] ver_linux: ppp.patch
The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to be
found in field 3 as seen by 'awk'. Should the output format be different,
this approach would no longer be reliable.

The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.


Tested on:
Arch Linux

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux 2015-10-03 13:55:27.335666029 +0300
@@ -50,8 +50,13 @@
quota -V 2>&1 | grep version | awk \
'NR==1{print "quota-tools ", $NF}'

-pppd --version 2>&1| grep version | awk \
-'NR==1{print "PPP ", $3}'
+test -x "$pppd" &&
+$pppd --version 2>&1 |
+sed '
+ /version/!d
+ s/[^0-9\.]//g
+ s/^/PPP\t\t\t/
+'

isdnctrl 2>&1 | grep version | awk \
'NR==1{print "isdn4k-utils ", $NF}'

\
 
 \ /
  Last update: 2015-10-03 16:01    [W:1.494 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site