lkml.org 
[lkml]   [2015]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 12/24] ver_linux: pcmciautils.patch
The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to be
found in field 2 as seen by 'awk'. Should the output format be different,
this approach would no longer be reliable.

The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.



Tested on:
Arch Linux
openSuSE 13.2

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux 2015-10-03 13:54:28.929540028 +0300
@@ -42,7 +42,12 @@
xfs_db -V 2>&1 | grep version | awk \
'NR==1{print "xfsprogs ", $3}'

-pccardctl -V 2>&1| grep pcmciautils | awk '{print "pcmciautils
", $2}'
+test -x "$pccardctl" &&
+$pccardctl -V 2>&1 |
+sed '
+ /^\(pcmciautils\)[ \t]/!d
+ s//\1\t\t/
+'

cardmgr -V 2>&1| grep version | awk \
'NR==1{print "pcmcia-cs ", $3}'

\
 
 \ /
  Last update: 2015-10-03 16:01    [W:0.066 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site