Messages in this thread Patch in this message | | | From | Alexander Kapshuk <> | Date | Sat, 3 Oct 2015 16:34:48 +0300 | Subject | [PATCH 12/24] ver_linux: pcmciautils.patch |
| |
The current implementation uses both 'grep' and 'awk' for text processing here, which may be alright as a quick solution to be run on the command line. While in a script, 'sed' or 'awk' would be a better choice. On top of that, the current implementation expects the version number to be found in field 2 as seen by 'awk'. Should the output format be different, this approach would no longer be reliable.
The proposed implementation uses 'sed' as a more flexible tool to handle varying output formats.
Tested on: Arch Linux openSuSE 13.2
Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com> --- --- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300 +++ linux/scripts/ver_linux 2015-10-03 13:54:28.929540028 +0300 @@ -42,7 +42,12 @@ xfs_db -V 2>&1 | grep version | awk \ 'NR==1{print "xfsprogs ", $3}'
-pccardctl -V 2>&1| grep pcmciautils | awk '{print "pcmciautils ", $2}' +test -x "$pccardctl" && +$pccardctl -V 2>&1 | +sed ' + /^\(pcmciautils\)[ \t]/!d + s//\1\t\t/ +'
cardmgr -V 2>&1| grep version | awk \ 'NR==1{print "pcmcia-cs ", $3}'
| |