lkml.org 
[lkml]   [2015]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs
On Thu, Oct 29, 2015 at 08:19:25AM +0000, Naoya Horiguchi wrote:
> On Tue, Oct 06, 2015 at 06:23:53PM +0300, Kirill A. Shutemov wrote:
> ...
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 0268013cce63..45fadab47c53 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma,
> > if (PageAnon(new))
> > hugepage_add_anon_rmap(new, vma, addr);
> > else
> > - page_dup_rmap(new);
> > + page_dup_rmap(new, false);
>
> This is for hugetlb page, so the second argument should be true, right?

You are right. Fixup:

index 1ae0113559c9..b1034f9c77e7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma,
if (PageAnon(new))
hugepage_add_anon_rmap(new, vma, addr);
else
- page_dup_rmap(new, false);
+ page_dup_rmap(new, true);
} else if (PageAnon(new))
page_add_anon_rmap(new, vma, addr, false);
else
--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2015-10-29 22:41    [W:0.224 / U:13.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site