Messages in this thread | | | From | Thomas Rohwer <> | Date | Thu, 29 Oct 2015 20:36:35 +0100 | Subject | Re: [PATCH] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl |
| |
> I suggest to add an anonymous union and add a u64 member that would > force the type width: > > struct btrfs_ioctl_send_args { > __s64 send_fd; /* in */ > __u64 clone_sources_count; /* in */ > union { > __u64 __user *clone_sources; /* in */ > u64 __pointer_alignment; > }; > __u64 parent_root; /* in */ > __u64 flags; /* in */ > __u64 reserved[4]; /* in */ > };
I am no expert, but would this change alone modify the user space ABI of a 32-bit Linux kernel? I.e. people in the (presumably currently working) btrfs-send situation (32-bit) user space/32-bit kernel would have to upgrade user space tools and kernel at the same time. Otherwise, they will encounter a non-working setup. I think, my suggested patch does not change any working ABI, and no change to the user space tools are necessary.
Sincerely,
Thomas Rohwer
| |