Messages in this thread | | | Subject | Re: [PATCH v2] pwm-backlight: fix the panel power sequence | From | Philipp Zabel <> | Date | Thu, 29 Oct 2015 16:40:59 +0100 |
| |
Hi YH,
Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > In the case of the panel disabled by the bootloader, > your patch still has the following code and always enables the backlight > in the probe function. > pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", > - GPIOD_OUT_HIGH);
You are right.
> What do you think if I remove these two lines in my patch? > if (pb->enable_gpio) > gpiod_direction_output(pb->enable_gpio, 0);
That won't work if the gpio is still configured as input. How about I add the GPIOD_ASIS change to my patch you remove that and the above from yours?
best regards Philipp
| |