Messages in this thread | | | Subject | Re: [PATCH v3] um: net: replace GFP_KERNEL with GFP_ATOMIC when spinlock is held | From | Richard Weinberger <> | Date | Thu, 29 Oct 2015 16:00:48 +0100 |
| |
Am 29.10.2015 um 15:50 schrieb Joe Perches: > On Thu, 2015-10-29 at 14:46 +0530, Saurabh Sengar wrote: >> replace GFP_KERNEL with GFP_ATOMIC while spinlock is held, >> as code while holding a spinlock should be atomic. >> GFP_KERNEL may sleep and can cause deadlock, >> where as GFP_ATOMIC may fail but certainly avoids deadlock >> >> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> >> --- >> v3: removed the atomic variable, as per Richard comment > > Trivia: You could remove the gfp_mask variables too > and just use GFP_KERNEL and GFP_ATOMIC directly.
Yep. And "int gfp_mask" does also not make sense, GFP_* is of type gfp_t.
Thanks, //richard
| |