lkml.org 
[lkml]   [2015]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S input controller
From
Date
On 28/10/15 01:04, Mark Brown wrote:
> On Tue, Oct 27, 2015 at 01:55:27PM +0000, Damien Horsley wrote:
>> On 23/10/15 23:57, Mark Brown wrote:
>
>>> Shouldn't we be doing that flush on stream close instead? If nothing
>>> else the flush is going to discard a bit of data if the stream is just
>>> paused.
>
>> The FIFOs are only 8 frames in size, so I am not sure there is an
>> issue with these frames being lost.
>
>> I think it also makes sense to keep the blocks consistent with each
>> other. The spdif (out and in), and parallel out, all flush automatically
>> when stopped, and the fifo for the i2s out block is cleared when the
>> reset is asserted.
>
> This seems like an issue that got missed in the other drivers then. I'd
> expect the trigger operation to be a minimal operation which starts and
> stops the data transfer, not doing anything else.
>

The spdif out, spdif in, and parallel out blocks auto-flush whenever
they are stopped. It is not possible for software to prevent this behavior.


\
 
 \ /
  Last update: 2015-10-28 22:41    [W:1.487 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site