Messages in this thread | | | Date | Wed, 28 Oct 2015 21:53:30 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis |
| |
On Wed, Oct 28, 2015 at 07:13:24PM +0100, Bogicevic Sasa wrote: > This fixes all Alignment should match open parenthesis > messages from checkpatch.pl > > Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com> > --- > drivers/staging/gdm724x/gdm_lte.c | 69 +++++++++++++++++++++++++-------------- > 1 file changed, 45 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c > index a8d2cff..a28e0d1 100644 > --- a/drivers/staging/gdm724x/gdm_lte.c > +++ b/drivers/staging/gdm724x/gdm_lte.c > @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type) > return -ENOMEM; > skb_reserve(skb_out, NET_IP_ALIGN); > > - memcpy(skb_put(skb_out, mac_header_len), mac_header_data, > + memcpy( > + skb_put(skb_out, mac_header_len), mac_header_data, > mac_header_len);
No. This isn't the right way. Look at other code to see how it's done.
regards, dan carpenter
| |