Messages in this thread | | | Date | Wed, 28 Oct 2015 16:20:42 +0100 | Subject | Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources | From | Linus Walleij <> |
| |
On Tue, Oct 27, 2015 at 6:54 PM, Grygorii Strashko <grygorii.strashko@ti.com> wrote: > [Me] >> Do you mean that these functions contain calls to non-atomic >> functions? >> > > Oh. No, I have to be more specific :( > if GPIOx driver defines custom .irq_(request|release)_resources() callbacks > they will *overwrite* standard GPIOirqchip callbacks. > (commit: 8b67a1f "gpio: don't override irq_*_resources() callbacks") > > As result, such GPIOx driver should *re-implement* the same functionality in > its .irq_(request|release)_resources() callbacks as implemented in > gpiochip_irq_reqres()/gpiochip_irq_relres().
Yes that goes for all drivers not using gpiochip_add_irqchip(). Not everyone uses that ... and for those supplying their own implementations of these functions.
Yours, Linus Walleij
| |