Messages in this thread | | | From | Hannes Frederic Sowa <> | Subject | Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops | Date | Wed, 28 Oct 2015 14:42:43 +0100 |
| |
Hello,
On Wed, Oct 28, 2015, at 14:32, Dan Streetman wrote: > On Tue, Oct 27, 2015 at 12:15 PM, <dan.streetman@canonical.com> wrote: > > From: Dan Streetman <dan.streetman@canonical.com> > > > > The ipv4 and ipv6 xfrms each create a template dst_ops object, and > > perform dst_entries_init() on the template objects. Then each net > > namespace has its net.xfrm.xfrm[46]_dst_ops field set to the template > > values. The problem with that is the dst_ops.pcpuc_entries field is > > a percpu counter and cannot be used correctly by simply copying it to > > another object.
How hard would it be to split of the counters from the dst_ops struct? We could make dst_ops instances const and have normal pointers to them and keep the dst_entries as a small array in net namespace?
Bye, Hannes
| |