lkml.org 
[lkml]   [2015]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 14/15] scsi: ufs: commit descriptors before setting the doorbell
    Date
    Add a write memory barrier to make sure descriptors prepared are actually
    written to memory before ringing the doorbell. We have also added the
    write memory barrier after ringing the doorbell register so that
    controller sees the new request immediately.

    Reviewed-by: Dolev Raviv <draviv@codeaurora.org>
    Signed-off-by: Gilad Broner <gbroner@codeaurora.org>
    Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
    Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>

    ---
    drivers/scsi/ufs/ufshcd.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
    index dfc4ac1..ec90504 100644
    --- a/drivers/scsi/ufs/ufshcd.c
    +++ b/drivers/scsi/ufs/ufshcd.c
    @@ -1628,6 +1628,8 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,

    hba->dev_cmd.complete = &wait;

    + /* Make sure descriptors are ready before ringing the doorbell */
    + wmb();
    spin_lock_irqsave(hba->host->host_lock, flags);
    ufshcd_send_command(hba, tag);
    spin_unlock_irqrestore(hba->host->host_lock, flags);
    --
    1.8.5.2
    --
    QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


    \
     
     \ /
      Last update: 2015-10-28 14:41    [W:4.173 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site