Messages in this thread | | | Date | Wed, 28 Oct 2015 14:26:56 +0900 (KST) | From | Jiri Kosina <> | Subject | Re: [PATCH] w1: w1_process() is not freezable kthread |
| |
On Tue, 27 Oct 2015, Evgeniy Polyakov wrote:
> > w1_process() calls try_to_freeze(), but the thread doesn't mark itself > > freezable through set_freezable(), so the try_to_freeze() call is useless. > > I believe it is better to mark it freezable, what do you think? Its task > is useless if anyone else goes sleeping, it should freeze too.
I fail to see why this kthread should be freezable at all. There is no way for w1 device to generate new I/O requests that should be written out to filesystem, is it?
Thanks,
-- Jiri Kosina SUSE Labs
| |