lkml.org 
[lkml]   [2015]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] coccinelle: misc: remove "complex return code" warnings
From
Date
Dne 28.10.2015 v 10:54 Johan Hovold napsal(a):
> On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote:
>> Should have acked this message...
>>
>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> On Wed, 30 Sep 2015, Johan Hovold wrote:
>>
>>> This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch
>>> to delete overly complex return code processing").
>>>
>>> There can be both symmetry and readability reasons for not wanting to do
>>> the final function call as part of the return statement and to maintain
>>> a clear separation of success and error paths.
>>>
>>> Since this is in no way mandated by the coding standard, let's just
>>> remove this semantic patch to avoid having "clean up" patches being
>>> posted over and over in response to these Coccinelle warnings.
>>>
>>> Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Is anyone planning on picking this patch up?

It is already in kbuild.git as commit 1a617a8475e8, I apparenly forgot
to reply to this thread.

Michal



\
 
 \ /
  Last update: 2015-10-28 11:41    [W:0.101 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site