Messages in this thread | | | Date | Tue, 27 Oct 2015 21:31:52 +0100 | Subject | Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board | From | Maxime Coquelin <> |
| |
2015-10-26 14:41 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>: > On Sat, Oct 17, 2015 at 7:23 PM, Maxime Coquelin > <mcoquelin.stm32@gmail.com> wrote: > >> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> > (...) >> + leds { >> + compatible = "gpio-leds"; >> + red { >> + gpios = <&gpiog 14 0>; >> + }; >> + green { >> + gpios = <&gpiog 13 0>; >> + }; > > I suggest you add labels to these LEDs. > > label = "red-LED" > label = "green-LED" > > This make things so much easier in sysfs.
I'm not sure to understand where it makes things easier in sysfs. This is the sysfs path for the red led: /sys/class/leds/red/
Indeed, if label is not present, it gets the node name.
> > Usually people also want to add a default linux,trigger to these, > like linux,default-trigger = "heartbeat"; but whatever you prefer.
Makes sense, I will add default trigger in next version.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks! Maxime
| |