lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] get_maintainer: Don't fallback to git by default
From
Date
On Tue, 2015-10-27 at 11:29 +0100, Wolfram Sang wrote:
> > act as reviewers, they should have a mention in MAINTAINERS for
> > get_maintiner.pl to pull information from:
> >
> > R: Designated reviewer: FullName <address@domain>
> > These reviewers should be CCed on patches.
>
> I think this should do.
>
> Interested parties should start by scanning the mailing list :)

I think the concept of reviewers is fine.

A couple weeks ago, I suggested a mechanism to have reviewers
concentrate their entries into separate REVIEWERS file(s)

https://lkml.org/lkml/2015/10/16/649

These REVIEWERS* files would also work for companies that have
people with specific areas of expertise that want internal review
before public exposure.

Kconfig and Makefile files in directories like drivers/i2c/busses
are outliers because all new individual drivers are added to both
files.

The mechanism to limit git-fallback use is a directory depth match.

Wolfram has a MAINTAINERS entry of:
F: drivers/i2c/
but that doesn't pattern doesn't match the directory depth of
file drivers/i2c/busses/Kconfig so git-fallback is used for files
that don't have specific MAINTAINERS.

It _might_ make some sense to limit activation of git history in
that specific case, but for some path like arch/, that limitation
might _not_ make sense.




\
 
 \ /
  Last update: 2015-10-27 19:01    [W:0.062 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site