lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 57/70] cpufreq: interactive: fix compiling warnings
    Date
    From: Chih-Wei Huang <cwhuang@linux.org.tw>

    The gcc warns like:

    cpufreq_interactive.c:745:6: warning: operation on 'ret' may be undefined [-Wsequence-point]

    It was introduced by commit cf0fad49d17cb8273ce555dd5b7afab67d7923bf.

    Since sprintf(...) just return 1 (one character) in this case, ret should not changed.
    Just discarding the result of sprintf(...) leads to the result that
    the committer of cf0fad49d17cb8273ce555dd5b7afab67d7923bf wants.

    Change-Id: Ifed1cef6d6a31c3ed23dad03a567b3b9eddf3a57
    Signed-off-by: Chih-Wei Huang <cwhuang@android-x86.org>
    Signed-off-by: Bálint Czobor <czoborbalint@gmail.com>
    ---
    drivers/cpufreq/cpufreq_interactive.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/cpufreq/cpufreq_interactive.c b/drivers/cpufreq/cpufreq_interactive.c
    index d72e8c4..9f63bd1 100644
    --- a/drivers/cpufreq/cpufreq_interactive.c
    +++ b/drivers/cpufreq/cpufreq_interactive.c
    @@ -752,7 +752,7 @@ static ssize_t show_target_loads(
    ret += sprintf(buf + ret, "%u%s", tunables->target_loads[i],
    i & 0x1 ? ":" : " ");

    - ret += sprintf(buf + --ret, "\n");
    + sprintf(buf + ret - 1, "\n");
    spin_unlock_irqrestore(&tunables->target_loads_lock, flags);
    return ret;
    }
    @@ -792,7 +792,7 @@ static ssize_t show_above_hispeed_delay(
    tunables->above_hispeed_delay[i],
    i & 0x1 ? ":" : " ");

    - ret += sprintf(buf + --ret, "\n");
    + sprintf(buf + ret - 1, "\n");
    spin_unlock_irqrestore(&tunables->above_hispeed_delay_lock, flags);
    return ret;
    }
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2015-10-27 19:01    [W:3.883 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site