Messages in this thread | | | Subject | Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS | From | John Garry <> | Date | Tue, 27 Oct 2015 15:06:56 +0000 |
| |
>>> The syscon block is a general subsystem control block, and it is not >>> specifically only for controlling reset and enabling clocks (other >>> functions include serdes control, for example). It is also shared >>> with other peripherals. >>> >>> So we can remove the ctrl-reg property (since it is not part of the >>> SAS controller), and add the relevant syscon register offsets to the >>> "hisilicon,sas-syscon" property, like this: >>> hisilicon,sas-syscon = <&sas_ctrl0 0xa60 0x33c 0x5a30 0xa64 0x338>; >>> >>> Ok? >> >> It would be better to have each offset in a separate property. >> > These register are not used for different purpose. > Instead, they are all used for one purpose, reset the sas controller; > Though a bit complicated, the silicon has special requirement here. > > So still prefer using the original method, > ctrl-reg = <0xa60 0x33c 0x5a30 0xa64 0x338>; > Since we can simply use of_property_read_u32_array. > We can actually remove the deassert and clock enable properties as they are always at a fixed offset from their respective assert/clk disable partner register.
> Thanks > > > . >
thanks, John
| |