Messages in this thread | | | Date | Tue, 27 Oct 2015 11:10:09 +0900 | From | Vinod Koul <> | Subject | Re: [PATCH V3 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA |
| |
On Fri, Oct 16, 2015 at 08:35:19AM +0100, Jon Hunter wrote: > +static inline void tdma_ch_write(struct tegra_adma_chan *tdc, > + u32 reg, u32 val)
Coding style issue here
> +static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) > +{ > + struct tegra_adma_chan *tdc = to_tegra_adma_chan(dc); > + int ret; > + > + ret = pm_runtime_get_sync(tdc2dev(tdc)); > + if (ret) > + return ret;
pm_runtime_get_sync() return postive values on success too, so this can fail. This check should be for less than zero case
-- ~Vinod
| |