Messages in this thread | | | Date | Mon, 26 Oct 2015 14:57:47 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 03/52] perf tools: Add thread_map event |
| |
Em Mon, Oct 26, 2015 at 06:55:45PM +0100, Jiri Olsa escreveu: > On Mon, Oct 26, 2015 at 02:48:25PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > > > u32 next_prev_tid; > > > > }; > > > > > > > > +struct thread_map_data_event { > > > > > > Humm, I think "data" here is way too vague here, how about > > > "thread_map_event_entry"? > > > > > > Moving of "entry" to the end also helps in understanding that this is > > > not an "event" per se, it doesn't have the perv_event_header, etc, its > > > just an entry in a 'struct thread_map_event'. > > > > > > I'm tentatively doing this change in my local branch, please let me know > > > if you have any reason to object to such a change, > > > > The resulting patch, that I'm merging with this one: > > > seems ok, thanks
Thanks for checking, hopefully I can push this today.
- Arnaldo
| |