Messages in this thread | | | Date | Mon, 26 Oct 2015 10:52:33 -0600 | Subject | Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models | From | Azael Avalos <> |
| |
Hi there,
Sorry for the late reply :-(
2015-10-21 2:48 GMT-06:00 Darren Hart <dvhart@infradead.org>: > On Tue, Oct 20, 2015 at 12:32:45AM +0100, Ben Hutchings wrote: >> On Sat, 2015-10-17 at 18:55 -0700, Greg Kroah-Hartman wrote: >> > 4.2-stable review patch. If anyone has any objections, please let me know. >> > >> > ------------------ >> > >> > From: Azael Avalos <coproscefalo@gmail.com> >> > >> > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream. >> > >> > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function >> > for keymap choosing") changed the *setup_keyboard function to query for >> > the Hotkey Event Type to help choose the correct keymap, but turns out >> > that here are certain Toshiba models out there not implementing this >> > feature, and thus, failing to continue the input device registration and >> > leaving such laptops without hotkey support. >> > >> > This patch changes such check, and instead of returning an error if >> > the Hotkey Event Type is not present, we simply inform userspace about it, >> > changing the message printed from err to notice, making the function >> > responsible for registering the input device to continue. >> [...] >> >> But then this function proceeds without events_type being initialised >> at all, with unpredictable results. This doesn't look like a proper >> fix. > > Azael, Ben has a point. Even after later patches, dev->hotkey_event_type doesn't > have a default value, so the later check for HCI_SYSTEM_TYPE1 or > HCI_SYSTEM_TYPE2 or failure is unpredictable.
Yes, I see the issue here. Since the function was returning before the variable value didin't matter, and when "fixing" the issue on the mentioned model I never took the variable initialization into account.
I'll send a patch probably later today addressing this issue.
> > -- > Darren Hart > Intel Open Source Technology Center
Cheers Azael
-- -- El mundo apesta y vosotros apestais tambien --
| |