lkml.org 
[lkml]   [2015]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

* Alexei Starovoitov <ast@plumgrid.com> wrote:

> On 10/23/15 5:03 AM, Peter Zijlstra wrote:
> >So the bpf_perf_event_read() returns the count value, does this not also
> >mean that returning -EINVAL here is also 'wrong'?
> >
> >I mean, sure an actual count value that high is unlikely, but its still
> >a broken interface.
>
> Agree. that's not pretty interface. I wish I looked at it more carefully
> when it was introduced. Now it's too late to change.

So I really, really think eBPF needs to have an easy to use mechanism to phase out
old ABI components and introducing new (better) ones!

Then old crap can be de-emphasised and eventually removed, instead of having to
live with crap forever ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-10-25 10:41    [W:0.097 / U:4.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site