lkml.org 
[lkml]   [2015]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] x86: Fix reading the current exposure value of UVC
Date
Hi Anton,

Thank you for the patch.

On Sunday 18 October 2015 17:01:26 Anton V. Shokurov wrote:
> V4L2_CID_EXPOSURE_ABSOLUTE property does not return an updated value when
> autoexposure (V4L2_CID_EXPOSURE_AUTO) is turned on. This patch fixes this
> issue by adding the UVC_CTRL_FLAG_AUTO_UPDATE flag.
>
> Tested on a C920 camera.

This looks good to me and I've successfully tested the patch.

> Signed-off-by: Anton V. Shokurov <shokurov.anton.v@yandex.ru>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied to my tree, I'll push it upstream for v4.5 (the merge window for v4.4
will open in a week only and with the Kernel Summit going on this week pushing
patches for v4.4 is difficult).

> ---
> drivers/media/usb/uvc/uvc_ctrl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c
> b/drivers/media/usb/uvc/uvc_ctrl.c index 3e59b28..c2ee6e3 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -227,7 +227,8 @@ static struct uvc_control_info uvc_ctrls[] = {
> .size = 4,
> .flags = UVC_CTRL_FLAG_SET_CUR
>
> | UVC_CTRL_FLAG_GET_RANGE
>
> - | UVC_CTRL_FLAG_RESTORE,
> + | UVC_CTRL_FLAG_RESTORE
> + | UVC_CTRL_FLAG_AUTO_UPDATE,
> },
> {
> .entity = UVC_GUID_UVC_CAMERA,

--
Regards,

Laurent Pinchart


\
 
 \ /
  Last update: 2015-10-26 04:41    [W:0.052 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site