lkml.org 
[lkml]   [2015]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL 0/2] perf/core new features

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 80fcd45ee05b4ef05e61d37a5ffb70a67095a9f6:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-23 10:25:57 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 161d9041782b86c5493481566539bfc058ceeaff:
>
> perf tools: Provide help for subset of options (2015-10-23 21:50:50 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements:
>
> New features:
>
> - Show ordered command line options when -h is used or when an
> unknown option is specified (Arnaldo Carvalho de Melo)
>
> - If options are passed after -h, show just its descriptions, not
> all options (Arnaldo Carvalho de Melo)

Very nice!

> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf tools: Show tool command line options ordered
> perf tools: Provide help for subset of options
>
> tools/perf/util/parse-options.c | 90 ++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 81 insertions(+), 9 deletions(-)

Pulled, thanks a lot Arnaldo!

So I tested this a bit, and the ordering works well.

What wasn't so obvious to me was behavior like:

triton:~/tip> perf report -h x

Usage: perf report [<options>]


triton:~/tip>

triton:~/tip> perf report -h exclude-other

Usage: perf report [<options>]


triton:~/tip>

I.e. it outputs nothing and does not tell the user what's wrong.

Then I figured out the right syntax:

triton:~/tip> perf report -h --exclude-other

Usage: perf report [<options>]

-x, --exclude-other Only display entries with parent-match

triton:~/tip>

:)

So maybe we should also try a search for the option name with a '-' and '--'
prepended? Also, my pet peeve are partial matches:

triton:~/tip> perf report -h --exclude

Usage: perf report [<options>]


triton:~/tip>

But in any case it's a nice step forward!

Ingo


\
 
 \ /
  Last update: 2015-10-25 10:01    [W:0.083 / U:2.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site