[lkml]   [2015]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec
On Mon, Oct 19, 2015 at 09:33:20AM +0200, dave penkler wrote:
> Implement support for the USB488 defined READ_STATUS_BYTE and SRQ
> notifications with ioctl, fasync and poll/select in order to be able
> to synchronize with variable duration instrument operations.
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> Add convenience ioctl to return all device capabilities.

Can you break this up into a series of patches, all doing only one
thing? You are doing a lot of different things in this single patch,
making it almost impossible to review :(


greg k-h

 \ /
  Last update: 2015-10-25 10:01    [W:0.055 / U:6.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site