lkml.org 
[lkml]   [2015]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free
On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote:
> This patch is to the wilc_wfi_cfgoperations.c file that fixes up
> following error reported by coccicheck:
>
> ERROR: reference preceded by free on line 1219
>
> For (params->seq_len) <= 0 memory is already freed when
> (params->seq_len) >0 then memory was alloted. So there is no need to use
> kfree whenever params->seq_len <=0 remove it and place kfree inside
> (params->seq_len) >0 condition.
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index bcbf1bd..9b3cf04 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1216,11 +1216,10 @@ static int add_key(struct wiphy *wiphy, struct net_device *netdev, u8 key_index,
>
> priv->wilc_ptk[key_index]->key = kmalloc(params->key_len, GFP_KERNEL);
>
> - kfree(priv->wilc_ptk[key_index]->seq);
> -
> - if ((params->seq_len) > 0)
> + if ((params->seq_len) > 0) {
> + kfree(priv->wilc_ptk[key_index]->seq);
> priv->wilc_ptk[key_index]->seq = kmalloc(params->seq_len, GFP_KERNEL);
> -
> + }

Are you sure about this? It seems like you are changing the logic
here...



\
 
 \ /
  Last update: 2015-10-25 20:41    [W:0.085 / U:8.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site