lkml.org 
[lkml]   [2015]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade
On Sun, Oct 25, 2015 at 04:15:17PM +0700, Lars Melin wrote:
> On 2015-10-24 22:44, Michele Baldessari wrote:
> >The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> >to have the two distinct joysticks working.
> >
> >Before the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >jstest: No such file or directory
> >
> >After the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >
> >Signed-off-by: Michele Baldessari <michele@acksyn.org>
> >---
> > drivers/hid/usbhid/hid-quirks.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> >index 1dff8f0015ba..f69049314a2c 100644
> >--- a/drivers/hid/usbhid/hid-quirks.c
> >+++ b/drivers/hid/usbhid/hid-quirks.c
> >@@ -150,6 +150,7 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> > { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> > { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> >+ { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
> >
> > { 0, 0 }
> > };
> >
>
> Sorry but I don't believe that XIN_MO is the owner of the 16c0 VID so should
> not be given that ownership in linux.

The "ownership" of 16c0 is a completely orthogonal issue to this patch.

16c0 was already defined (twice actually):
$ grep -i 0x16c0 drivers/hid/hid-ids.h | awk '{ print $2 }'
USB_VENDOR_ID_ATMEL_V_USB
USB_VENDOR_ID_XIN_MO

cheers,
Michele
--
Michele Baldessari <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B D0BC DDD4 DCCB 7515 5C6D


\
 
 \ /
  Last update: 2015-10-25 17:41    [W:0.065 / U:12.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site