lkml.org 
[lkml]   [2015]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 4/8] clk: rockchip: add new pll-type for rk3036 and similar socs
Date
Hi,

Am Samstag, 24. Oktober 2015, 18:30:25 schrieb Xing Zheng:
> The rk3036's pll and clock are different with base on the rk3066(rk3188,
> rk3288, rk3368 use it), there are different adjust foctors and control
> registers, so these should be independent and separate from the series
> of rk3066s.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
>

> +static void rockchip_rk3036_pll_init(struct clk_hw *hw)
> +{

In the previous version, Stephen requested that we don't use regular clock
APIs in the init-callback. I did a modification for the already present pll-
type in [0], which got already accepted. So you should probably also modify
your pll-type in this fashion :-) .

Oh and I guess patches 3 and 4 should switch places ... adding the pll-type
before the code in the clock-controller using it.


Heiko


[0] https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=8334c0e7b983fb27e0d8788901e9621d1946ba93



\
 
 \ /
  Last update: 2015-10-24 13:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog