lkml.org 
[lkml]   [2015]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] lustre: obdclass: fix sparse warning
This patch fixes the following warnings given by the sparse:

drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static?
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static?

Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++--
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
index 6218ef3..45d92c2 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
@@ -421,7 +421,7 @@ static struct attribute_group lustre_attr_group = {
.attrs = lustre_attrs,
};

-int class_procfs_init(void)
+static int class_procfs_init(void)
{
int rc = -ENOMEM;
struct dentry *file;
@@ -457,7 +457,7 @@ out:
return rc;
}

-int class_procfs_clean(void)
+static int class_procfs_clean(void)
{
if (debugfs_lustre_root != NULL)
debugfs_remove_recursive(debugfs_lustre_root);
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index 1515163..6f13f21 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -158,11 +158,11 @@ static struct attribute_group lustre_attr_group = {
.attrs = lustre_attrs,
};

-int obd_sysctl_init(void)
+static int obd_sysctl_init(void)
{
return sysfs_create_group(lustre_kobj, &lustre_attr_group);
}

-void obd_sysctl_clean(void)
+static void obd_sysctl_clean(void)
{
}
--
1.9.1


\
 
 \ /
  Last update: 2015-10-24 09:41    [W:0.046 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site