lkml.org 
[lkml]   [2015]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6] coccinelle: Improve checking for missing NULL terminators
    Date
    * Extend checking on tables containing structures which are
    initialized without specifying member name. Added new tables
    for checking: i2c_device_id and platform_device_id.

    Signed-off-by: Daniel Granat <d.granat@samsung.com>
    ---
    scripts/coccinelle/misc/of_table.cocci | 33 ++++++++++++++++++++++++++++-----
    1 file changed, 28 insertions(+), 5 deletions(-)

    diff --git a/scripts/coccinelle/misc/of_table.cocci b/scripts/coccinelle/misc/of_table.cocci
    index 3c93404..2294915 100644
    --- a/scripts/coccinelle/misc/of_table.cocci
    +++ b/scripts/coccinelle/misc/of_table.cocci
    @@ -1,6 +1,6 @@
    -/// Make sure of_device_id tables are NULL terminated
    +/// Make sure (of/i2c/platform)_device_id tables are NULL terminated
    //
    -// Keywords: of_table
    +// Keywords: of_table i2c_table platform_table
    // Confidence: Medium
    // Options: --include-headers

    @@ -13,18 +13,26 @@ virtual report
    identifier var, arr;
    expression E;
    @@
    -struct of_device_id arr[] = {
    +(
    +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
    ...,
    {
    .var = E,
    * }
    };
    +|
    +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
    + ...,
    +* { ..., E, ... },
    +};
    +)

    @depends on patch@
    identifier var, arr;
    expression E;
    @@
    -struct of_device_id arr[] = {
    +(
    +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
    ...,
    {
    .var = E,
    @@ -32,19 +40,34 @@ struct of_device_id arr[] = {
    + },
    + { }
    };
    +|
    +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
    + ...,
    + { ..., E, ... },
    ++ { },
    +};
    +)

    @r depends on org || report@
    position p1;
    identifier var, arr;
    expression E;
    @@
    -struct of_device_id arr[] = {
    +(
    +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
    ...,
    {
    .var = E,
    }
    @p1
    };
    +|
    +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
    + ...,
    + { ..., E, ... }
    + @p1
    +};
    +)

    @script:python depends on org@
    p1 << r.p1;
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-10-23 18:01    [W:4.180 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site