lkml.org 
[lkml]   [2015]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 2/3] thermal: rockchip: support the sleep pinctrl state to avoid glitches in s2r
From
Caesar,

On Fri, Oct 23, 2015 at 4:25 AM, Caesar Wang <wxt@rock-chips.com> wrote:
> When we come out of system suspend state (S3) the tsadc will have been
> reset and back at its default state. While reprogramming the tsadc
> it's possible that we'll glitch the output and unintentionally cause
> the "over temperature" GPIO to be asserted. Since the over
> temperature GPIO is often hooked up to something that will cause a
> reboot or shutdown in hardware, this glitch can be catastrophic on
> some boards.
>
> We'll add support for selecting the "sleep" pinctrl state at suspend
> time. Boards can use this to effectively disable the tsadc at suspend
> time and avoid glitches when the system is resumed.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>
> ---
>
> Changes in v4:
> - take the Doug's commit as correct decription.
>
> Changes in v3:
> - Add the pinctrl state for in the suspend/resume.
>
> Changes in v2: None
> Changes in v1: None
>
> drivers/thermal/rockchip_thermal.c | 4 ++++
> 1 file changed, 4 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>


\
 
 \ /
  Last update: 2015-10-23 18:01    [W:0.111 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site