lkml.org 
[lkml]   [2015]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper
    On Fri, Oct 23, 2015 at 07:42:22AM -0700, Alexei Starovoitov wrote:
    > On 10/23/15 5:03 AM, Peter Zijlstra wrote:
    > >So the bpf_perf_event_read() returns the count value, does this not also
    > >mean that returning -EINVAL here is also 'wrong'?
    > >
    > >I mean, sure an actual count value that high is unlikely, but its still
    > >a broken interface.
    >
    > Agree. that's not pretty interface. I wish I looked at it more carefully
    > when it was introduced. Now it's too late to change.

    Right; and I figure changing the function signature is not done because
    the eBPF stuff is ABI? Unfortunate indeed.


    \
     
     \ /
      Last update: 2015-10-23 17:01    [W:4.160 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site