Messages in this thread | | | Date | Fri, 23 Oct 2015 19:52:51 +0900 | Subject | Re: [PATCH 1/3] i2c: uniphier: add UniPhier FIFO-less I2C driver | From | Masahiro Yamada <> |
| |
Hi Wolfram,
Thanks for your review!
2015-10-23 5:59 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>: > On Thu, Jul 30, 2015 at 05:12:20PM +0900, Masahiro Yamada wrote: >> Add support for on-chip I2C controller used on old UniPhier SoCs >> such as PH1-LD4, PH1-sLD8, etc.. This adapter is so simple that >> it has no FIFO in it. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Finally! Mostly looking good. > >> +static u32 uniphier_i2c_functionality(struct i2c_adapter *adap) >> +{ >> + return I2C_FUNC_I2C; >> +} > > No I2C_FUNC_SMBUS_EMUL? But check if SMBUS_QUICK is supported by your > adapter.
Added in v2.
>> + regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + if (!regs) { >> + dev_err(dev, "failed to get memory resource"); >> + return -EINVAL; >> + } > > This 'if'-block can go. devm_ioremap_resource will check it for you. >
Fixed in v2.
Thanks!
-- Best Regards Masahiro Yamada
| |