lkml.org 
[lkml]   [2015]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Y2038] [PATCH V2] hp_sdc: fixed y2038 problem
Date
On Friday 23 October 2015 16:53:26 WEN Pingbo wrote:
> 1. Converting timeval to ktime_t, and there is no need to handle sec and
> usec separately
>
> 2. hp_sdc.rtv is only used for time diff, monotonic time is better here
>
> Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org>
> ---

This version is still correct and looks better than the first version, but
I'd still like you to improve some details:

- read some other changelogs and follow the common style. In particular,
in the subject line say /what/ you do ("e.g. use ktime_get instead of
do_gettimeofday", or "avoid using struct timespec") instead of /why/,
but then explain in the changelog text what is wrong with the current
version and why it gets changed like this.

- Below the '---', add a short list of things you have changed since
the previous versions. This part will not get copied into the git
history.

> - do_gettimeofday(&tv);
> - if (tv.tv_sec > hp_sdc.rtv.tv_sec)
> - tv.tv_usec += USEC_PER_SEC;
> -
> - if (tv.tv_usec - hp_sdc.rtv.tv_usec > HP_SDC_MAX_REG_DELAY) {
> + if (time_diff.tv64 > HP_SDC_MAX_REG_DELAY) {
> hp_sdc_transaction *curr;
> uint8_t tmp;
>
> - printk(KERN_WARNING PREFIX "read timeout (%ius)!\n",
> - (int)(tv.tv_usec - hp_sdc.rtv.tv_usec));
> + printk(KERN_WARNING PREFIX "read timeout (%llins)!\n",
> + time_diff.tv64);
> curr->idx += hp_sdc.rqty;
> hp_sdc.rqty = 0;
> tmp = curr->seq[curr->actidx];

A tiny style comment here: please use ktime_to_ns() to extract the
nanoseconds out of the ktime_t type rather than accessing the tv64
member directly.

Arnd


\
 
 \ /
  Last update: 2015-10-23 11:41    [W:0.076 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site