Messages in this thread | | | Date | Thu, 22 Oct 2015 15:29:33 -0700 | Subject | Re: [PATCH v2 1/5] pmem, dax: clean up clear_pmem() | From | Dan Williams <> |
| |
On Thu, Oct 22, 2015 at 1:48 PM, Jeff Moyer <jmoyer@redhat.com> wrote: > Dan Williams <dan.j.williams@intel.com> writes: > >> Both, __dax_pmd_fault, and clear_pmem() were taking special steps to >> clear memory a page at a time to take advantage of non-temporal >> clear_page() implementations. However, x86_64 does not use >> non-temporal instructions for clear_page(), and arch_clear_pmem() was >> always incurring the cost of __arch_wb_cache_pmem(). >> >> Clean up the assumption that doing clear_pmem() a page at a time is more >> performant. > > Wouldn't another solution be to actually use non-temporal stores?
Sure.
> Why did you choose to punt?
Just a priority call at this point. Patches welcome of course ;-).
| |